Regex

[bleonard]

Just looking at the code as I'm doing something similar
There's a regex here

/ secure;/

I'm pretty sure it should be

/; secure/

As the current case does not handle secure being the last piece of the header.
Maybe it's not an issue in how rack or rails does things, but it seems like you could end up with it there twice.

[rymai]

Hi, thanks.

I don't think your proposal would handle secure being the first piece of the header, though.

I think /(;\s+)?secure/ would be better to handle all the cases, wdyt?

[bleonard]

i've never seen it first, but I have seen it last. it's usually the name, first. I think your regex might be not be good on cookies named "secure" or "secure_anything".
I suppose /(^|;\s)secure[$;]/ might be closer.

[rymai]

Good point!

I think this would be even better then: (;\s+)?secure($|;) (and works as expected, as shown here).

[tobmatth]

Thank you guys, i decided to go with @rymai's last proposal...

[bleonard]

Sorry, missed this comment. WIthout doingt the beginning of line, that regex has an issue if the value ends in the string secure
http://rubular.com/r/miVoJAVpDl

Mine didn't match just secure on the line but i don't think that's valid
http://rubular.com/r/JYaImKwmKz

[rymai]

Sorry, you're right, the following Regex should be more rock-solid: http://rubular.com/r/aGG9VYAWFM

Do you think it's ok with this one?