Feat(clickhouse): support CREATE VIEW TO syntax (#1752)

* Feat(clickhouse): support CREATE VIEW TO syntax * fix db/catalog and TO token
tobymao · Jun 9, 2023 · 99c41d9 · 99c41d9
1 parent c6a540c
commit 99c41d9
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -1869,6 +1869,10 @@ class EngineProperty(Property):
     arg_types = {"this": True}
 
 
+class ToTableProperty(Property):
+    arg_types = {"this": True}
+
+
 class ExecuteAsProperty(Property):
     arg_types = {"this": True}
 

diff --git a/sqlglot/generator.py b/sqlglot/generator.py
@@ -86,6 +86,7 @@ class Generator:
         exp.SettingsProperty: lambda self, e: f"SETTINGS{self.seg('')}{(self.expressions(e))}",
         exp.SqlSecurityProperty: lambda self, e: f"SQL SECURITY {'DEFINER' if e.args.get('definer') else 'INVOKER'}",
         exp.TemporaryProperty: lambda self, e: f"TEMPORARY",
+        exp.ToTableProperty: lambda self, e: f"TO {self.sql(e.this)}",
         exp.TransientProperty: lambda self, e: "TRANSIENT",
         exp.StabilityProperty: lambda self, e: e.name,
         exp.VolatileProperty: lambda self, e: "VOLATILE",
@@ -228,6 +229,7 @@ class Generator:
         exp.SqlSecurityProperty: exp.Properties.Location.POST_CREATE,
         exp.StabilityProperty: exp.Properties.Location.POST_SCHEMA,
         exp.TemporaryProperty: exp.Properties.Location.POST_CREATE,
+        exp.ToTableProperty: exp.Properties.Location.POST_SCHEMA,
         exp.TransientProperty: exp.Properties.Location.POST_CREATE,
         exp.MergeTreeTTL: exp.Properties.Location.POST_SCHEMA,
         exp.VolatileProperty: exp.Properties.Location.POST_CREATE,

diff --git a/sqlglot/parser.py b/sqlglot/parser.py
@@ -634,6 +634,7 @@ class Parser(metaclass=_Parser):
         "TBLPROPERTIES": lambda self: self._parse_wrapped_csv(self._parse_property),
         "TEMP": lambda self: self.expression(exp.TemporaryProperty),
         "TEMPORARY": lambda self: self.expression(exp.TemporaryProperty),
+        "TO": lambda self: self._parse_to_table(),
         "TRANSIENT": lambda self: self.expression(exp.TransientProperty),
         "TTL": lambda self: self._parse_ttl(),
         "USING": lambda self: self._parse_property_assignment(exp.FileFormatProperty),
@@ -1050,6 +1051,12 @@ def _parse_comment(self, allow_exists: bool = True) -> exp.Expression:
             exp.Comment, this=this, kind=kind.text, expression=self._parse_string(), exists=exists
         )
 
+    def _parse_to_table(
+        self,
+    ) -> exp.ToTableProperty:
+        table = self._parse_table_parts(schema=True)
+        return self.expression(exp.ToTableProperty, this=table)
+
     # https://clickhouse.com/docs/en/engines/table-engines/mergetree-family/mergetree#mergetree-table-ttl
     def _parse_ttl(self) -> exp.Expression:
         def _parse_ttl_action() -> t.Optional[exp.Expression]:

diff --git a/tests/dialects/test_clickhouse.py b/tests/dialects/test_clickhouse.py
@@ -45,6 +45,12 @@ def test_clickhouse(self):
         self.validate_identity(
             "CREATE MATERIALIZED VIEW test_view ON CLUSTER cl1 (id UInt8) ENGINE=AggregatingMergeTree() ORDER BY tuple() AS SELECT * FROM test_data"
         )
+        self.validate_identity(
+            "CREATE MATERIALIZED VIEW test_view ON CLUSTER cl1 (id UInt8) TO table1 AS SELECT * FROM test_data"
+        )
+        self.validate_identity(
+            "CREATE MATERIALIZED VIEW test_view (id UInt8) TO db.table1 AS SELECT * FROM test_data"
+        )
 
         self.validate_all(
             r"'Enum8(\'Sunday\' = 0)'", write={"clickhouse": "'Enum8(''Sunday'' = 0)'"}