Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subquery selects #1569

Merged
merged 4 commits into from
May 9, 2023
Merged

fix: subquery selects #1569

merged 4 commits into from
May 9, 2023

Conversation

barakalon
Copy link
Collaborator

We weren't propagating selects from subqueries

georgesittas
georgesittas approved these changes May 9, 2023
View reviewed changes
sqlglot/expressions.py Outdated Show resolved Hide resolved
georgesittas
georgesittas reviewed May 9, 2023
View reviewed changes
sqlglot/expressions.py Outdated Show resolved Hide resolved
sqlglot/expressions.py Outdated Show resolved Hide resolved
tobymao
tobymao reviewed May 9, 2023
View reviewed changes
sqlglot/expressions.py Outdated Show resolved Hide resolved
@barakalon barakalon merged commit bcfae2c into main May 9, 2023
@barakalon barakalon deleted the barak/subquery-types branch May 9, 2023 01:08
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@barakalon @adrianisk
fix: subquery selects (tobymao#1569)
f40181b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao left review comments

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barakalon @tobymao @georgesittas