Feat(clickhouse): parse ternary operator #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
May 12, 2023
| @@ -2985,8 +2999,18 @@ def _parse_column(self) -> t.Optional[exp.Expression]: | |||
| field = self._parse_types() | |||
| if not field: | |||
| self.raise_error("Expected type") | |||
| elif op: | |||
| elif op and self._curr: | |||
There was a problem hiding this comment.
Without self._curr here we might raise an index error in the self._advance call below (happened earlier).
georgesittas
commented
May 12, 2023
sqlglot/parser.py
Outdated
Comment on lines
3008
to
3009
| self._prev.token_type != TokenType.STRING | ||
| or self._match_set(self.TERNARY_OPERATOR_TOKENS) |
There was a problem hiding this comment.
If the prev token is a STRING we can't immediately disambiguate between a JSONBContains expression (x ? 'foo' in postgres) and a ternary operator.
|
With these additions our parser is actually more lenient than Clickhouse's. For example, we can handle this: >>> import sqlglot
>>> sqlglot.parse_one("x ? y ? 1 : 2 : 3")
(IF this:
(COLUMN this:
(IDENTIFIER this: x, quoted: False)), true:
(IF this:
(COLUMN this:
(IDENTIFIER this: y, quoted: False)), true:
(LITERAL this: 1, is_string: False), false:
(LITERAL this: 2, is_string: False)), false:
(LITERAL this: 3, is_string: False))Whereas Clickhouse fails to parse it: 
|
|
maybe this should be clickhouse only so you don't have to worry about conflicts. also, maybe you should treat it like the exponent use case for postgres. it can have another precedence |
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
* Feat(clickhouse): parse ternary operator * Formatting * Refactor * Fixup * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1602