Chore: issue a warning if __version__ can't be imported #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
May 18, 2023
sqlglot/__init__.py
Outdated
| except ImportError: | ||
| pass | ||
| logger.warning("Unable to set __version__, consider installing SQLGlot first.") |
There was a problem hiding this comment.
make this more explicit, so not consider installing
tell them to run
pip install -e . or python setup.py develop
There was a problem hiding this comment.
and don't make this a warning, make it an error
There was a problem hiding this comment.
@tobymao I wonder whether this message will always be printed when using sqlglot simply for its interface (i.e. not developing in it). For example, if you import sqlglot or use its CLI as: python -m sqlglot ..., will it still log? If so, do we want it to log?
There was a problem hiding this comment.
Seems like it is printed regardless:
➜ sqlglot git:(jo/warn_about_version) python -m sqlglot "select foo"
Unable to set __version__, run `pip install -e .` or `python setup.py develop` first.
SELECT
"foo"This is without having a _version.py file at all.
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
* Chore: issue a warning if __version__ can't be imported * PR feedback * Replace 'consider installing' with 'run'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.