Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(clickhouse): allow aliases in tuple function arguments #1695

Merged
merged 4 commits into from
May 26, 2023
Merged

Fix(clickhouse): allow aliases in tuple function arguments #1695

merged 4 commits into from
May 26, 2023

Conversation

georgesittas
Copy link
Collaborator

Fixes #1690

@georgesittas georgesittas requested a review from tobymao May 25, 2023 23:59
tobymao
tobymao reviewed May 26, 2023
View reviewed changes
sqlglot/parser.py Outdated Show resolved Hide resolved
@tobymao tobymao merged commit 8465a77 into main May 26, 2023
@tobymao tobymao deleted the jo/clickhouse_tuple_fix branch May 26, 2023 00:34
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@georgesittas @adrianisk
Fix(clickhouse): allow aliases in tuple function arguments (tobymao#1695
c54acdc 
)

* Fix(clickhouse): allow aliases in tuple function arguments

* Refactor to use set

* fixup

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid ClickHouse expression fails to parse
2 participants
@georgesittas @tobymao