Fix(bigquery): allow SPLIT call with 1 argument #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
Jun 13, 2023
sqlglot/dialects/bigquery.py
Outdated
Comment on lines
194
to
197
| "SPLIT": lambda args: exp.Split( | ||
| # https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#split | ||
| this=seq_get(args, 0), expression=seq_get(args, 1) or exp.Literal.string(",") | ||
| ), |
There was a problem hiding this comment.
This is the only actual addition (& the corresponding test)
tobymao
approved these changes
Jun 13, 2023
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
* Fix(bigquery): allow SPLIT call with 1 argument * Formatting * Reorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: reordered some tests to partition them into validate_all / validate_identity & sorted functions in alphabetical order