Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query param #146

Closed
raaraa opened this issue Oct 18, 2024 · 2 comments · Fixed by #147
Closed

Add query param #146

raaraa opened this issue Oct 18, 2024 · 2 comments · Fixed by #147
Assignees
Labels
enhancement New feature or request

Comments

@raaraa
Copy link

raaraa commented Oct 18, 2024

Could we add season as a query param to the schedules endpoint. Seems we would only have to add it to endpoints.py and the wiki. Happy to take this on if approved.

@toddrob99
Copy link
Owner

Interesting... I didn't realize the schedule endpoint supported season as a parameter. It looks like it basically pre-fills start and end date parameters for you. I have a couple other things that I've been putting off, so I'll add this when I get around to those. In the meantime you can still use the season parameter by passing force=True to statsapi.get(), e.g. statsapi.get("season", {"sportId": 1, "season": 2023}, force=True)

@toddrob99 toddrob99 self-assigned this Oct 18, 2024
@toddrob99 toddrob99 added the enhancement New feature or request label Oct 18, 2024
@raaraa
Copy link
Author

raaraa commented Oct 18, 2024

awesome, thanks!

@toddrob99 toddrob99 mentioned this issue Oct 26, 2024
@toddrob99 toddrob99 linked a pull request Oct 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants