Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition for seasons endpoint is missing season parameter #18

Closed
toddrob99 opened this issue Oct 4, 2019 · 1 comment
Closed

Definition for seasons endpoint is missing season parameter #18

toddrob99 opened this issue Oct 4, 2019 · 1 comment
Assignees
@toddrob99
Labels
bug Something isn't working

Comments

@toddrob99
Copy link
Owner

Seasons endpoint supports season parameter to get info about a given season. The endpoint definition is missing this parameter, so it will always return the current season unless the force option is used.
@toddrob99 toddrob99 added the bug Something isn't working label Oct 4, 2019
@toddrob99 toddrob99 self-assigned this Oct 4, 2019
@toddrob99 toddrob99 mentioned this issue Oct 4, 2019
Merged
@toddrob99
Copy link
Owner Author

Note: The season endpoint (singular season vs. seasons) does accept seasonId parameter and will return the same data.

toddrob99 added a commit that referenced this issue Oct 18, 2019
@toddrob99
v0.1.3
d262492 
FIXED:

- #18 Definition for seasons endpoint is missing season parameter
- #20 Update endpoint requirements for stats_streaks

ENHANCED:

- #19 Use logging module instead of print for debug info
- Added more fields to boxscore and standings data functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddrob99 toddrob99

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toddrob99