Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split search input by word #143

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

ap-ack
Copy link
Contributor

@ap-ack ap-ack commented Jun 28, 2024

@toddrob99
Copy link
Owner

Are you able to provide some timing comparisons, to see how much performance is impacted by this change? With the way you did it, I'm guessing it's minimal.

@ap-ack
Copy link
Contributor Author

ap-ack commented Aug 15, 2024

I measured my code as consistently running 1-2 ms slower than yours, even for single-word search inputs where we couldn't attribute this difference to the algorithm change. So I tried replacing the all/any functions with for-else loops, which to my surprise measured 1-2 ms faster than the existing code, even for multi-word cases. So I pushed that optimization.

Findings attached and as noted, this measures only the search so negates the network call latency, which far outweighs the search anyway.

stats-lookup-analysis.xlsx

@toddrob99 toddrob99 merged commit 4587c35 into toddrob99:develop Oct 26, 2024
@ap-ack ap-ack deleted the issue-138/splitSearch branch November 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants