Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash-completion #242

Closed
wants to merge 3 commits into from
Closed

Fix bash-completion #242

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2018

Further Fixes #221

For more standard, bash completion file should be installed in $(datarootdir)/bash-completion/completions/ . I see quite a lot of packages(like tc udisksctl etc) have bash completion files installed under that directory, and For me $(datarootdir)/bash_completion.d doesn't exist at all.

@karbassi karbassi added this to the Version 2.12.0 milestone Mar 26, 2018
@karbassi
Copy link
Member

Sadly this doesn't fix the problem globally. Maybe we can fix this by following an example from another package, for example git-extras.

https://github.com/tj/git-extras/blob/4.5.0/Makefile#L59-L63

PREFIX ?= /usr/local
SYSCONFDIR ?= $(PREFIX)/etc

@mkdir -p $(DESTDIR)$(SYSCONFDIR)/bash_completion.d
cp -f etc/bash_completion.sh $(DESTDIR)$(SYSCONFDIR)/bash_completion.d/git-extras

@ghost
Copy link
Author

ghost commented Mar 29, 2018

I don't know about MAC, but modern linux distros,like Arch amd Gentoo, use $(datarootdir)/bash-completion/completions/ as the default completion directory, I think I should follow this packaging rule. I encounterred this last year when I packaged it. And I thought it was worth to report and open PR for it.

karbassi added a commit that referenced this pull request Mar 29, 2020
karbassi added a commit that referenced this pull request Mar 29, 2020
wwalker pushed a commit to wwalker/todo.txt-cli that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant