Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: yocto logic sync #543

Merged
merged 4 commits into from
Sep 27, 2023
Merged

chore: yocto logic sync #543

merged 4 commits into from
Sep 27, 2023

Conversation

darkskygit
Copy link
Member

No description provided.

forehalo and others added 3 commits September 27, 2023 17:07
* feat: node binding part 1

* feat: add text editing support

* feat: array editing

* feat: add map binding

* feat: add apis for benchmark

* feat: process array correctly

* feat: insert object in map

* chore: cleanup codes

* feat: rename clearly params

* test: don’t tolerate optional values in testing

* feat: create anonymous array/map/text

* feat: get ytype dynamically

* feat: add some compatibility test with yjs

* feat: map interoperability for yjs

* fix: lint
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 10:31am

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (7d37ab5) 65.99% compared to head (dddf70c) 65.78%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   65.99%   65.78%   -0.22%     
==========================================
  Files         115      117       +2     
  Lines       12626    12710      +84     
==========================================
+ Hits         8333     8361      +28     
- Misses       4293     4349      +56     
Files Coverage Δ
libs/jwst-codec-utils/src/doc.rs 100.00% <100.00%> (ø)
libs/jwst-codec/src/codec/integer.rs 94.59% <100.00%> (-0.57%) ⬇️
libs/jwst-codec/src/doc/codec/item.rs 78.74% <100.00%> (ø)
libs/jwst-codec/src/doc/codec/refs.rs 75.07% <100.00%> (ø)
libs/jwst-codec/src/doc/codec/utils/items.rs 76.11% <100.00%> (ø)
libs/jwst-codec/src/doc/history.rs 89.47% <100.00%> (-0.13%) ⬇️
libs/jwst-codec/src/doc/publisher.rs 90.58% <100.00%> (+0.76%) ⬆️
libs/jwst-codec/src/doc/types/array.rs 94.48% <100.00%> (-0.04%) ⬇️
libs/jwst-codec/src/doc/types/list/iterator.rs 100.00% <ø> (ø)
libs/jwst-codec/src/doc/types/list/mod.rs 86.92% <100.00%> (+0.26%) ⬆️
... and 23 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

let ty = self.as_inner().ty();

if let Some(ty) = ty {
let ty = Arc::new(ty);

Check warning

Code scanning / clippy

usage of an `Arc` that is not `Send` or `Sync`

usage of an `Arc` that is not `Send` or `Sync`
@darkskygit darkskygit temporarily deployed to development September 27, 2023 10:30 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 27, 2023 10:30 — with GitHub Actions Inactive
@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 328.9±0.14µs 328.8±0.17µs -0.03%
codec/jwst decode var_uint (32 bit) 411.9±0.16µs 280.7±0.76µs -31.85%
codec/jwst decode var_uint (64 bit) 289.1±0.19µs 289.0±0.12µs -0.03%
codec/jwst encode var_int (32 bit) 427.3±0.22µs 427.3±0.16µs -0.00%
codec/jwst encode var_uint (32 bit) 318.3±0.09µs 318.6±1.30µs +0.09%
codec/jwst encode var_uint (64 bit) 318.3±0.15µs 318.3±0.16µs -0.00%
codec/lib0 decode var_int (64 bit) 298.7±0.74µs 299.1±0.73µs +0.13%
codec/lib0 decode var_uint (32 bit) 418.8±2.07µs 262.3±0.12µs -37.37%
codec/lib0 decode var_uint (64 bit) 357.2±0.34µs 240.5±0.23µs -32.67%
codec/lib0 encode var_int (64 bit) 533.5±17.42µs 529.7±3.36µs -0.71%
codec/lib0 encode var_uint (32 bit) 353.9±1.86µs 374.4±4.46µs +5.79%
codec/lib0 encode var_uint (64 bit) 391.4±7.20µs 377.1±7.85µs -3.65%
ops/array/jwst/insert 273.7±0.47µs 262.0±1.08µs -4.27%
ops/array/jwst/insert range 400.7±0.45µs 382.4±0.75µs -4.57%
ops/array/jwst/remove 168.6±0.06µs 161.9±0.16µs -3.97%
ops/array/yrs/insert 92.6±0.31µs 89.1±0.61µs -3.78%
ops/array/yrs/insert range 115.3±1.04µs 116.4±0.32µs +0.95%
ops/array/yrs/remove 96.1±0.60µs 107.2±0.23µs +11.55%
ops/map/jwst/get 508.0±10.61ns 461.5±3.28ns -9.15%
ops/map/jwst/insert 6.5±0.02µs 6.4±0.02µs -1.54%
ops/map/jwst/remove 8.2±0.02µs 8.0±0.02µs -2.44%
ops/map/yrs/get 359.0±2.13ns 365.4±3.82ns +1.78%
ops/map/yrs/insert 6.1±0.01µs 5.8±0.01µs -4.92%
ops/map/yrs/remove 7.7±0.02µs 7.8±0.05µs +1.30%
ops/text/jwst/insert 149.3±0.25µs 135.7±0.10µs -9.11%
ops/text/jwst/remove 3.3±0.03µs 3.4±0.00µs +3.03%
ops/text/yrs/insert 44.1±0.08µs 41.5±0.09µs -5.90%
ops/text/yrs/remove 2.5±0.01µs 2.4±0.01µs -4.00%
update/parse with jwst/basic.bin 68.5±0.05µs 57.0±0.06µs -16.79%
update/parse with jwst/database.bin 54.7±0.08µs 46.2±0.15µs -15.54%
update/parse with jwst/large.bin 3.5±0.03ms 2.9±0.00ms -17.14%
update/parse with jwst/with-subdoc.bin 6.5±0.01µs 5.9±0.20µs -9.23%
update/parse with yrs/basic.bin 44.6±0.07µs 45.1±0.05µs +1.12%
update/parse with yrs/database.bin 35.6±0.12µs 35.6±0.16µs -0.00%
update/parse with yrs/large.bin 2.2±0.00ms 2.2±0.00ms -0.00%
update/parse with yrs/with-subdoc.bin 6.5±0.01µs 4.6±0.01µs -29.23%

Benchmark for Windows

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 530.8±6.84µs 468.5±6.40µs -11.74%
codec/jwst decode var_uint (32 bit) 435.8±9.43µs 432.8±6.61µs -0.69%
codec/jwst decode var_uint (64 bit) 486.3±6.52µs 322.8±3.73µs -33.62%
codec/jwst encode var_int (32 bit) 443.1±6.79µs 431.1±5.06µs -2.71%
codec/jwst encode var_uint (32 bit) 310.8±4.78µs 337.9±6.24µs +8.72%
codec/jwst encode var_uint (64 bit) 310.7±4.14µs 350.4±7.31µs +12.78%
codec/lib0 decode var_int (64 bit) 436.8±11.46µs 430.6±5.55µs -1.42%
codec/lib0 decode var_uint (32 bit) 243.9±3.35µs 242.9±3.19µs -0.41%
codec/lib0 decode var_uint (64 bit) 244.0±3.43µs 354.8±4.50µs +45.41%
codec/lib0 encode var_int (64 bit) 591.7±71.35µs 600.0±6.87µs +1.40%
codec/lib0 encode var_uint (32 bit) 397.7±4.53µs 395.3±5.36µs -0.60%
codec/lib0 encode var_uint (64 bit) 417.0±7.98µs 406.0±5.59µs -2.64%
ops/array/jwst/insert 303.0±5.05µs 286.5±11.63µs -5.45%
ops/array/jwst/insert range 425.3±5.95µs 394.3±3.77µs -7.29%
ops/array/jwst/remove 173.8±2.43µs 166.2±1.72µs -4.37%
ops/array/yrs/insert 110.4±2.16µs 113.8±1.13µs +3.08%
ops/array/yrs/insert range 151.7±1.89µs 152.8±2.00µs +0.73%
ops/array/yrs/remove 165.1±1.91µs 159.0±2.04µs -3.69%
ops/map/jwst/get 531.8±5.72ns 487.3±10.01ns -8.37%
ops/map/jwst/insert 9.9±0.11µs 8.2±0.09µs -17.17%
ops/map/jwst/remove 10.6±0.15µs 10.2±0.10µs -3.77%
ops/map/yrs/get 354.4±7.46ns 355.9±7.40ns +0.42%
ops/map/yrs/insert 10.2±0.10µs 8.0±0.09µs -21.57%
ops/map/yrs/remove 10.7±0.11µs 10.5±0.11µs -1.87%
ops/text/jwst/insert 177.0±2.68µs 158.7±3.75µs -10.34%
ops/text/jwst/remove 4.8±0.05µs 4.9±0.07µs +2.08%
ops/text/yrs/insert 47.5±0.47µs 48.3±0.43µs +1.68%
ops/text/yrs/remove 4.5±0.05µs 4.6±0.04µs +2.22%
update/parse with jwst/basic.bin 97.8±1.05µs 83.7±1.01µs -14.42%
update/parse with jwst/database.bin 76.8±0.61µs 63.8±1.06µs -16.93%
update/parse with jwst/large.bin 4.6±0.15ms 3.9±0.14ms -15.22%
update/parse with jwst/with-subdoc.bin 15.1±0.15µs 11.3±0.11µs -25.17%
update/parse with yrs/basic.bin 66.4±1.15µs 67.6±0.58µs +1.81%
update/parse with yrs/database.bin 52.1±0.56µs 52.2±0.44µs +0.19%
update/parse with yrs/large.bin 3.1±0.07ms 3.1±0.13ms -0.00%
update/parse with yrs/with-subdoc.bin 11.5±0.14µs 12.3±0.24µs +6.96%

@darkskygit darkskygit merged commit c989a55 into master Sep 27, 2023
@darkskygit darkskygit deleted the darksky/yocto-sync branch September 27, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants