fix: playground not working on firefox #3824
Merged
+11
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
fourdim
approved these changes
Aug 3, 2023
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to toeverything/AFFiNE#3494
The issue of
DOMException: IDBDatabase.transaction: 'workspace' is not a known object store nameerror is that in Firefox thetestIDBExistencefunction will create an empty DB that will result in skipping upgrading the DB that is defined in affine.I have checked the new implementation of
testIDBExistenceand it shall not create a new DB in both Chrome and Firefox on callingtestIDBExistence. However I think you may need to remove the localPLAYGROUND_DBone in Firefox, or passing?initin the query params to make it work.