Scan GUIDs #7
Merged
Scan GUIDs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uids_clean_v4 # Conflicts: # pkg/host/types/interfaces.go
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
clarkzinzow
approved these changes
Feb 11, 2025
| @@ -722,7 +722,12 @@ func (cr *SriovIBNetwork) RenderNetAttDef() (*uns.Unstructured, error) { | |||
| data.Data["CapabilitiesConfigured"] = true | |||
| data.Data["SriovCniCapabilities"] = cr.Spec.Capabilities | |||
| } | |||
|
|
|||
| if cr.Spec.PKey == "" { | |||
| data.Data["pKeyConfigured"] = false | |||
There was a problem hiding this comment.
Hmm why do we need this boolean? Can't we just check for a non-empty pKey string field?
There was a problem hiding this comment.
Tried to do that - didn't seem that simple, so followed the pattern I saw here (e.g CapabilitiesConfigured, LogLevelConfigured, LogFileConfigured etc.
punkerpunker
merged commit 82b5147
into
clark/config-daemon-ib-unbind-fix
14 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.