Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't appear all my coins when I run "balance" command #15

Open
dsiervo opened this issue May 18, 2017 · 6 comments
Open

Don't appear all my coins when I run "balance" command #15

dsiervo opened this issue May 18, 2017 · 6 comments

Comments

@dsiervo
Copy link

dsiervo commented May 18, 2017

  • Cointrader version: 0.4.0
  • Python version: 2.7
  • Operating System: Ubuntu

Description

I was trying to get my balance trough balance command, but the result only
show 3 of my 8 bags in poloniex.
How would I get my complete balance? Thanks for you reply.
Describe what you were trying to get done.

What I Did

cointrader balance

The output

CUR          total    btc_value
-------------------------------
DASH:   0.77820928   0.03538021
NXT :   1.04353182    3.303e-05
USDT:    9.433e-05          0.0
BTC :        1e-08        1e-08
-------------------------------
TOTAL BTC:           0.03541325
TOTAL USD:        66.6486326323

@toirl
Copy link
Owner

toirl commented May 18, 2017

Hi.Thanks for your report.
Cointrader currently does only list currencies with a balance > 0. Do the missing ones have a positive balance? Which one are you missing, then I can check if the currency is actually included in the response from the server.

Torsten

@dsiervo
Copy link
Author

dsiervo commented May 19, 2017

Hi, thank you so much for your prompt response.
Yes, the missing ones have positive balance and are:
ETC, ETH, GNT and XRP

@toirl
Copy link
Owner

toirl commented May 22, 2017

@dsiervo I will check the code.

@toirl
Copy link
Owner

toirl commented May 22, 2017

Tests show that ETC, ETH, GNT and XRP are actually included in the response from the server. So I assume there is an issue with filtering the coins. The patch on https://gist.github.com/toirl/5b786e9bbb8c152bd50a51727de33300 removes the filtering completely. So applying this on recent master results in the currency get listed when invoking the balance command.

Can you confirm this?

@dsiervo
Copy link
Author

dsiervo commented May 25, 2017

Hi, applying the patch it shows me all of the coins in poloniex and therefore my complete balance.
But, I saw that the coins that beofore didn't appear, this time they have zero value in the total column.
As you can see, this is an extract of total output:

CUR          total    btc_value
-------------------------------
XRP :          0.0     0.012299
ULTC:          0.0          0.0
ECC :          0.0          0.0
GNT :          0.0   0.08754492

toirl added a commit that referenced this issue May 29, 2017
For currently unknown reasons the quantity of some coins in the balance
command are 0 but the calculated value in btc is larger than 0. To get
those coins at least listed within the balance command the if condition
to check wheter a coin is included or not was adapted. Leaving back the
issue of the empty quantity.
@toirl
Copy link
Owner

toirl commented May 29, 2017

@dsiervo I am sorry I can not repoduce this issue. I just bought some XRP to try to reproduce the reported issue with no success. Even very small amounts of coins seems to be listed just fine:

CUR          total    btc_value
 -------------------------------
BTC :    8.911e-05    8.911e-05
DASH:   0.37822886   0.01911998
XRP :         3.99   0.00041057


But I changed the check condition in the code to check for the btc_value ans not for the quantity of coins. This is a workaround to get at least the coins listed.

The issue not showing a quantity of coins still remains. I will file a new ticket for this: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants