Use Content-Length header more often. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikcorry
approved these changes
Jul 26, 2023
src/request.toit
Outdated
| slash := (path.starts_with "/") ? "" : "/" | ||
| body_writer := connection_.send_headers | ||
| "$method $slash$path HTTP/1.1\r\n" | ||
| headers | ||
| --is_client_request=true | ||
| --content_length=content_length | ||
| --has_body=(body != null) |
| body_writer_.write data | ||
|
|
||
| write_headers_ status_code/int --message/string? --has_body/bool: | ||
| write_headers_ status_code/int --message/string? --content_length/int? --has_body/bool: |
There was a problem hiding this comment.
I think it would save code to have content_length default to null here.
There was a problem hiding this comment.
keeping as is, to make callers think about the content-length.
We can't get the content-length in the write method because this is a method that can be called more than once. Fix some types in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.