Refactor the ADC to use the new API. #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
approved these changes
Feb 3, 2025
lib/gpio/adc.toit
Outdated
| $allow-restricted flag to allow its use. | ||
| */ | ||
| constructor .pin --max-voltage/float?=null --allow-restricted/bool=false: | ||
| constructor .pin --max-voltage/float?=null --allow-restricted/bool?=false: |
There was a problem hiding this comment.
Why is allow-restricted suddenly allowed to be null?
src/resources/adc_esp32.cc
Outdated
| #ifndef CONFIG_IDF_TARGET_ESP32C6 | ||
| esp_adc_cal_characteristics_t calibration; | ||
| #endif | ||
| adc_oneshot_unit_handle_t* unit; |
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| #include "../top.h" | |||
|
|
|||
| #ifdef TOIT_ESP32 | |||
| #if 0 // def TOIT_ESP32 | |||
There was a problem hiding this comment.
yes.
The I2S uses the ADC underneath. It's not allowed to use the old and new version of the ADC driver. Until the I2S code is updated it won't compile.
There is already a follow-up PR that fixes the I2S. (Otherwise, I would have added more comments).
Co-authored-by: Kasper Lund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.