Change default lint level to warning and deny warnings in CI #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the API we are currently using becomes deprecated, deprecated warnings may prevent previously released versions from compiling. It can work around by --cap-lints, but it is not very good.
As we already applied -Dwarnings in CI, this PR only changes denied lints in code:
bytes/.github/workflows/ci.yml
Lines 11 to 13 in a3304e8
Also, seem to there is no way to pass -Dwarnings to the doc tests at the time, so this PR doesn't change the lint level of the doc tests. However, as
#[doc(test(attr(deny(..)))]is enabled only when doc test is run, the above issue does not occur. See also rust-lang/futures-rs#1672 (comment) for this.Related: tokio-rs/tokio#1083 (comment), rust-lang/futures-rs#1448 (comment)