When connecting to url without http:// weird things are happening
#401
Labels
S-bug
Severity: bug
Comments
hds
pushed a commit
that referenced
this issue
Nov 3, 2023
Tokio console can connect to a console subscriber over HTTP or (on UNIX) via a socket. However, no check was performed to ensure that the server string matched the HTTP(S) or FILE protocols. This was reported to lead to strange behavior (#401). This change adds an explicit check on the URI scheme to ensure that it is one of `http`, `https`, or `file`. closes: #401 Signed-off-by: hi-rustin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What crate(s) in this repo are involved in the problem?
tokio-console
What is the issue?
First time using
tokio-console, I didtokio-console 127.0.0.1:1234and it kind of worked, not really. The display is blank, but when changing its size it displays something update reconnecting andt = tasks, r = resources, but doesn't seem to update anything.Eventually I figured out that I'm supposed to do
tokio-console http://127.0.0.1:1234and that gives me the UI.How can the bug be reproduced?
tokio-console 127.0.0.1:1234(nohttp://)Logs, error output, etc
No response
Versions
Possible solution
No response
Additional context
No response
Would you like to work on fixing this bug?
no
The text was updated successfully, but these errors were encountered: