Update formatting for rustfmt 1.4.12-stable #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of rustfmt for the varint! macro changes between rustfmt 1.4.11-stable and rustfmt 1.4.12-stable. The new formatting is acceptable to both versions.
dfreese
added a commit
to dfreese/prost
that referenced
this pull request
May 5, 2020
I've noticed a number of github actions reporting failing or cancelled on the cache step. This removes them, for now, to provide a better signal for the project, until why the cache action fails can be determined. Builds on PR tokio-rs#312.
|
Thanks for the PR. I ran rustfmt on another PR before seeing this, so the changes have already landed. |
danburkert
added a commit
that referenced
this pull request
May 10, 2020
* Update formatting for rustfmt 1.4.12-stable The handling of rustfmt for the varint! macro changes between rustfmt 1.4.11-stable and rustfmt 1.4.12-stable. The new formatting is acceptable to both versions. * Remove cache action step that is causing problems for CI I've noticed a number of github actions reporting failing or cancelled on the cache step. This removes them, for now, to provide a better signal for the project, until why the cache action fails can be determined. Builds on PR #312. * remove all caching Co-authored-by: David Freese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of rustfmt for the varint! macro changes between rustfmt
1.4.11-stable and rustfmt 1.4.12-stable. The new formatting is
acceptable to both versions.