This repository has been archived by the owner on Sep 13, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serve() and with_handle() now take a future which tell a TcpServer when
to shut down. The functions now also return a TcpServerHandle, a future
which resolves once the server has shut down.
Also added the serve_forever() convenience method with the old behavior
of serving forever.
I implemented the simplest possible codec and proto so that I could actually
instantiate a tcp server to test shutdown. Is there a better way?
Feel free to bikeshed away on the interface here, a lot could probably be
improved.
Fixes #101