Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] depends on outdated hashbrown #6101

Closed
dignifiedquire opened this issue Oct 23, 2023 · 3 comments · Fixed by #6102
Closed

[email protected] depends on outdated hashbrown #6101

dignifiedquire opened this issue Oct 23, 2023 · 3 comments · Fixed by #6102
Labels
A-tokio-util Area: The tokio-util crate C-bug Category: This is a bug.

Comments

@dignifiedquire
Copy link
Contributor

dignifiedquire commented Oct 23, 2023 •
edited
Loading

[email protected] depends currently on an outdated version of [email protected], which in turn depends on [email protected] which is yanked: https://github.com/tokio-rs/tokio/blob/master/tokio-util/Cargo.toml#L48
@dignifiedquire dignifiedquire added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Oct 23, 2023
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate and removed A-tokio Area: The main tokio crate labels Oct 24, 2023
@dignifiedquire dignifiedquire mentioned this issue Oct 24, 2023
Closed
@Darksonn
Copy link
Contributor

I'm happy to upgrade to hashbrown v0.14, but it doesn't seem like we force you to use a yanked version of ahash. Hashbrown v0.12.x is compatible with ahash 0.7.7, which is not yanked. Remember that cargo dependencies are caret-dependencies, and do not specify an exact version.

@dignifiedquire
Copy link
Contributor Author

Thanks, 0.7.7 was not yet released when I filed this issue, so it makes it much less urgent.
I'll make a PR updating hashbrown in any case though.

dignifiedquire added a commit to dignifiedquire/tokio that referenced this issue Oct 24, 2023
@dignifiedquire
deps(tokio-util): update hashbrown to 0.14
e5d9d00 
Closes tokio-rs#6101
@dignifiedquire dignifiedquire mentioned this issue Oct 24, 2023
Merged
@dignifiedquire
Copy link
Contributor Author

Opened #6102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps(tokio-util): update hashbrown to 0.14 dignifiedquire/tokio
2 participants
@dignifiedquire @Darksonn