time: Move DelayQueue to tokio-util #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
|
What part of the API was causing trouble? |
|
@Darksonn per @carllerche Tokio 1.0 won't initially expose DelayQueue as a stable API (see #2718), so this is moving it to tokio-util, which won't have the same stability guarantees. |
This change is intended to do the minimum to unblock 0.3; as such, for now, we duplicate the internal `time::wheel` structures in tokio-util, rather than trying to refactor things at this stage.
|
Force pushing to resolve conflicts. |
|
Not sure why the CI run was cancelled... Can someone please restart it? |
|
Done. |
Merged
|
Macos tests failed due to reaching unreachable code in the tokio scheduler... could this be an independent bug? @carllerche |
|
Failing line is https://github.com/tokio-rs/tokio/blob/master/tokio/tests/rt_common.rs#L569 Looks unrelated to the timer changes (but probably a legitimate bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to do the minimum to unblock 0.3; as such, for now, we
duplicate the internal
time::wheelstructures in tokio-util, rather than tryingto refactor things at this stage.