Issue 3608. Annotate struct EnterGuard with attr must_use #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnterGuard must always be used.
{
let _guard = handle.enter(); // skipping _guard is wrong in all likelihood
}
farazshaikh
changed the title
Darksonn
added
A-tokio
Darksonn
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnterGuard must always be used.
{
let _guard = handle.enter(); // skipping _guard is wrong in all likelihood
}
Motivation
Enterguard should be used. Without the let binding the its no-op.
Solution
Mark EnterGuard struct as must_use