Run basic scheduler destructor inside executor context #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
changed the title
Diggsey
force-pushed
the
db-spawn-on-shutdown-test
branch
from
ad90416 to
5b41b90
Compare
Darksonn
reviewed
Jul 18, 2021
Comment on lines
-304
to
306
| pub(crate) fn shutdown(mut self) { | ||
| pub(crate) fn shutdown(&mut self) { | ||
| self.spawner.shutdown(); | ||
| } |
There was a problem hiding this comment.
Adding a destructor to Runtime means we can no longer move out of the handle field, which would have made it impossible to call shutdown() on it. This was the simplest fix.
There was a problem hiding this comment.
(See the implementation of shutdown_timeout)
|
The CI failed again after restarting. I suspect there is a double panic somewhere. Try running them locally with |
|
Output is as expected when I run it locally: each of the panic tests panics once. |
Darksonn
added
A-tokio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963