Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a safe method to remove an item from the queue.
Fixes: #3558
Motivation
DelayQueue
does not expose any way to check that an item is present in its slab. On the other hand,remove
will panic if a client attempts to remove akey
that is not in the queue. As a result, client libraries that have to avoid panics must maintain an extraHashSet
around the queue.Solution
Add a
try_remove
method which performs an internal membership check before callingremove
. If a client attempts to remove akey
that isn't there,try_remove
will returnNone
instead of panicking.Since
try_remove
is the only method of its kind, I have elected to make it return anOption<Expired<T>>
insteadResult<Expired<T>, SomeNewErrorEnum>
, at least for now.