sync: useful Debug impl for RwLock #5647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the
std::fmt::Debug
impl fortokio::sync::RwLock
is just what#[derive(Debug)]
provides and looks likewhich isn't very useful. Instead we can show the data if no thread currently holds the write lock. This matches what is done in
std::sync::RwLock
and intokio::sync::Mutex
.Solution
The updated code is basically a 1 to 1 mapping from the tokio Mutex implementation.