-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more test to be tested with miri in CI #6885
Changes from 6 commits
91b3fa7
c75732b
842787d
9324ca2
1731493
5565479
879da01
40c3c26
146134d
dcdbadb
4a12abc
f1c36c9
936edf7
92fcd41
4f37518
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -420,14 +420,13 @@ jobs: | |
components: miri | ||
- uses: Swatinem/rust-cache@v2 | ||
- name: miri | ||
# Many of tests in tokio/tests and doctests use #[tokio::test] or | ||
# #[tokio::main] that calls epoll_create1 that Miri does not support. | ||
run: | | ||
cargo miri test --features full --lib --no-fail-fast | ||
rustup toolchain install nightly-2024-09-19 --component miri --profile minimal --no-self-update | ||
rustup override set nightly | ||
cargo miri test --features full --lib --tests --no-fail-fast | ||
working-directory: tokio | ||
env: | ||
MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-strict-provenance -Zmiri-retag-fields | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deleting this line seems like a spurious change. |
||
asan: | ||
name: asan | ||
needs: basics | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
#[test] | ||
#[cfg_attr(miri, ignore)] | ||
fn compile_fail_full() { | ||
let t = trybuild::TestCases::new(); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
#![warn(rust_2018_idioms)] | ||
#![cfg(not(target_os = "wasi"))] // Wasi doesn't support threads | ||
// Blocked on https://github.com/rust-lang/miri/issues/3911 | ||
#![cfg(not(miri))] | ||
Comment on lines
+3
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this fixed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but I don't think the latest fix is synced to rustc yet. |
||
|
||
use std::rc::Rc; | ||
use std::sync::Arc; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This both disables miri for the entire file and for specific tests. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, thanks for catching this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to keep the change minimal, so I don't really want to change
env.rust_nightly
, but I am not sure if this will work.EDIT: This won't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably want to get them back in sync as a follow-up PR, then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean
rust_miri_nightly
andrust_nightly
?