subscriber: fix missing event fields in Compact formatter
#1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbarsky
approved these changes
Nov 29, 2021
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Nov 29, 2021
# 0.3.3 (Nov 29, 2021) This release fixes a pair of regressions in `tracing-subscriber`'s `fmt` module. ### Fixed - **fmt**: Fixed missing event fields with `Compact` formatter ([#1755]) - **fmt**: Fixed `PrettyFields` formatter (and thus `format::Pretty` event formatter) ignoring the `fmt::Layer`'s ANSI color code configuration ([#1747]) [#1755]: #1755 [#1747]: #1747
hawkw
added a commit
that referenced
this pull request
Nov 29, 2021
# 0.3.3 (Nov 29, 2021) This release fixes a pair of regressions in `tracing-subscriber`'s `fmt` module. ### Fixed - **fmt**: Fixed missing event fields with `Compact` formatter ([#1755]) - **fmt**: Fixed `PrettyFields` formatter (and thus `format::Pretty` event formatter) ignoring the `fmt::Layer`'s ANSI color code configuration ([#1747]) [#1755]: #1755 [#1747]: #1747
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
…#1755) The line of code that prints the event's fields (including its message) was accidentally deleted in 0a16972, while backporting PR tokio-rs#1696 from `master` (where the `Compact` formatter implementation is significantly different). This branch puts it back. Also, I've added tests for the `Compact` formatter's output, to guard against accidentally breaking it in the future. Previously, we only had tests for the `Full` and `Json` formatters. Fixes tokio-rs#1741 Signed-off-by: Eliza Weisman <[email protected]>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.3.3 (Nov 29, 2021) This release fixes a pair of regressions in `tracing-subscriber`'s `fmt` module. ### Fixed - **fmt**: Fixed missing event fields with `Compact` formatter ([tokio-rs#1755]) - **fmt**: Fixed `PrettyFields` formatter (and thus `format::Pretty` event formatter) ignoring the `fmt::Layer`'s ANSI color code configuration ([tokio-rs#1747]) [tokio-rs#1755]: tokio-rs#1755 [tokio-rs#1747]: tokio-rs#1747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line of code that prints the event's fields (including its message)
was accidentally deleted in 0a16972,
while backporting PR #1696 from
master(where theCompactformatterimplementation is significantly different).
This branch puts it back. Also, I've added tests for the
Compactformatter'soutput, to guard against accidentally breaking it in the future. Previously, we
only had tests for the
FullandJsonformatters.Fixes #1741