tracing-journald: allow custom journal fields #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`custom_field` implied that the user could set this to anything; instead, the fields here have to be valid journal fields.
…funciton through the search function
Ralith
requested changes
Sep 1, 2023
This is harmless. We don't need to go way out of our way to prevent the user from deliberately sending strange things to journald. |
Ralith
reviewed
Sep 3, 2023
|
@Ralith What now? Waiting for more reviewers? |
Ralith
approved these changes
Sep 5, 2023
|
Yep, this LGTM so I expect @hawkw will merge once they have time to skim it. |
|
@Ralith Had to fix the doctest, might need a CI retrigger |
hawkw
approved these changes
Sep 5, 2023
|
@hawkw Thanks :) |
|
@Finomnis I'm hoping to get a bunch of releases out in the near future, hopefully today or tomorrow. Feel free to ping me if it doesn't happen! |
|
@hawkw Ping :) |
davidbarsky
pushed a commit
that referenced
this pull request
Sep 26, 2023
## Motivation It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. ## Solution Allow custom fields to be set in tracing-journald. ## Open Questions - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
davidbarsky
pushed a commit
that referenced
this pull request
Sep 27, 2023
## Motivation It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. ## Solution Allow custom fields to be set in tracing-journald. ## Open Questions - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
davidbarsky
pushed a commit
that referenced
this pull request
Sep 27, 2023
## Motivation It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. ## Solution Allow custom fields to be set in tracing-journald. ## Open Questions - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
davidbarsky
pushed a commit
that referenced
this pull request
Sep 27, 2023
It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. Allow custom fields to be set in tracing-journald. - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
davidbarsky
pushed a commit
that referenced
this pull request
Sep 27, 2023
It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. Allow custom fields to be set in tracing-journald. - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
davidbarsky
pushed a commit
that referenced
this pull request
Sep 27, 2023
It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. Allow custom fields to be set in tracing-journald. - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
davidbarsky
pushed a commit
that referenced
this pull request
Sep 29, 2023
It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. Allow custom fields to be set in tracing-journald. - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
hawkw
pushed a commit
that referenced
this pull request
Oct 1, 2023
It's currently not possible to customize how messages will get send to journald. This became apparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values. So in a sense, this is the successor/rework of #2425. Allow custom fields to be set in tracing-journald. - [x] How should we deal with fields that also get supplied by other options? For example, setting `SYSLOG_IDENTIFIER` here and also setting `.with_syslog_identifier()` will send said field twice, potentially with differing values. Is that a problem? - Answer: No, this is not a problem. Closes #2425
|
@hawkw I guess you are planning to release this as |
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.1 (November 29, 2024) [ [crates.io][crate-0.3.1] ] | [ [docs.rs][docs-0.3.1] ] ### Changed - disable default features of tracing-subscriber ([#1476]) - allow custom journal fields ([#2708]) - Bump MSRV to 1.63 ([#2793]) - make level mappings configurable ([#2824]) [#1476]: #1476 [#2708]: #2708 [#2793]: #2793 [#2824]: #2824 [docs-0.3.1]: https://docs.rs/tracing-journald/0.3.1 [crate-0.3.1]: https://crates.io/crates/tracing-journald/0.3.1
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.1 (November 29, 2024) [ [crates.io][crate-0.3.1] ] | [ [docs.rs][docs-0.3.1] ] ### Changed - disable default features of tracing-subscriber ([#1476]) - allow custom journal fields ([#2708]) - Bump MSRV to 1.63 ([#2793]) - make level mappings configurable ([#2824]) [#1476]: #1476 [#2708]: #2708 [#2793]: #2793 [#2824]: #2824 [docs-0.3.1]: https://docs.rs/tracing-journald/0.3.1 [crate-0.3.1]: https://crates.io/crates/tracing-journald/0.3.1
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.1 (November 29, 2024) [ [crates.io][crate-0.3.1] ] | [ [docs.rs][docs-0.3.1] ] ### Changed - disable default features of tracing-subscriber ([#1476]) - allow custom journal fields ([#2708]) - Bump MSRV to 1.63 ([#2793]) - make level mappings configurable ([#2824]) [#1476]: #1476 [#2708]: #2708 [#2793]: #2793 [#2824]: #2824 [docs-0.3.1]: https://docs.rs/tracing-journald/0.3.1 [crate-0.3.1]: https://crates.io/crates/tracing-journald/0.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's currently not possible to customize how messages will get send to journald.
This became aparent in #2425, where first a specific API got designed, but then it was decided that users should not get restricted in only a subset of fields, but should be able to simply choose by themselves what fields get set with what values.
So in a sense, this is the successor/rework of #2425.
Solution
Allow custom fields to be set in tracing-journald.
Open Questions
SYSLOG_IDENTIFIERhere and also setting.with_syslog_identifier()will send said field twice, potentially with differing values. Is that a problem?