-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare tracing-appender 0.2.3 release #2790
Merged
+37
−2
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7d0a977
chore: prepare tracing-subscriber 0.3.18 release
davidbarsky 0a759ed
Update tracing-subscriber/CHANGELOG.md
davidbarsky 7346ebc
Update tracing-subscriber/CHANGELOG.md
davidbarsky c6799f5
address review comments
davidbarsky 74679f7
Reflect MSRV update in changelog
davidbarsky b63abe3
Update date of release
davidbarsky 69fbc3e
chore: prepare tracing-appender 0.2.3
davidbarsky 270b48d
review nits
davidbarsky a12e122
update changelog to include the removed send bounds and MSRV bump
davidbarsky c486633
update release date
davidbarsky 764d011
Merge branch 'v0.1.x' into david/prepare-tracing-appender-0.2.3
davidbarsky 9e935ed
bump tracing-subscriber
davidbarsky 96c6b87
Update tracing-appender/CHANGELOG.md
hawkw 79aceda
Update tracing-appender/CHANGELOG.md
hawkw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
review nits
commit 270b48d653ba4a4ca0ec78bfa3d1c65b98217925
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like "added" to me, but your mileage may vary 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it's
added
. I'll make "changed" stuff for breaking changes and otherwise internal, but noteworthy, fixes.