examples: ignore failing MSRV in tower-load example #3122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using the `try_join!` macro from tokio in the tower-load example in the `tracing-examples` crate. With the latest version of Tokio (1.41.0), this macro needs Rust 1.64.0 to compile. Since an earlier version of Tokio has the same macro compiling on an earlier version of Rust, and because this is just an example, it doesn't make sense to bump the MSRV for this. The MSRV Clippy lint has been set to allow for this instance.
|
I'd rather we just bump the MSRV for examples (or remove it entirely?) |
|
@davidbarsky I've moved this change to a new PR (#3125) which is focused on the wasm32 failure, but also bumps the MSRV in This PR can now be closed as not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're using the
try_join!macro from tokio in the tower-load examplein the
tracing-examplescrate. With the latest version of Tokio(1.41.0), this macro needs Rust 1.64.0 to compile.
Since an earlier version of Tokio has the same macro compiling on an
earlier version of Rust, and because this is just an example, it doesn't
make sense to bump the MSRV for this.
Solution
The MSRV Clippy lint has been set to allow for this instance.