Appender: Add benchmarks #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main reason to benchmark the non-blocking writer, IMO, is to compare its performance with a synchronous (blocking) writer, so that we can assess the performance benefit of this approach. Can you add a benchmark for multiple threads writing synchronously, so that we can compare these? |
Sure, will do! |
hawkw
added a commit
that referenced
this pull request
May 5, 2020
Following the release process for https://github.com/tokio-rs/tracing/blob/master/CONTRIBUTING.md and these changes are the only things left to commit before release. I'd like to hopefully get this released today so we can start using this crate internally. Note: I need to get PR #703 and PR #678 merged before release. Co-authored-by: Zeki Sherif <[email protected]> Co-authored-by: Eliza Weisman <[email protected]>
|
This PR is really old, but AFAICT, if the branch were to be made up-to-date again, we could merge this. |
bryangarza
added a commit
to bryangarza/tracing
that referenced
this pull request
May 16, 2022
This patch adds blocking and nonblocking benchmarks. This code is from an old PR (tokio-rs#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]>
bryangarza
added a commit
that referenced
this pull request
May 23, 2022
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <[email protected]> Co-authored-by: David Barsky <[email protected]>
|
Closing since #2128 was merged :) |
hawkw
pushed a commit
that referenced
this pull request
Jun 6, 2022
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <[email protected]> Co-authored-by: David Barsky <[email protected]>
hawkw
pushed a commit
that referenced
this pull request
Jun 7, 2022
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <[email protected]> Co-authored-by: David Barsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We needed benchmarks for tracing-appender
Solution
Added benches for non_blocking only and for non_blocking which delegates to a rolling file appender.
This is my first time writing a bench :)