Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge V1.11 beta to Master #113

Merged
merged 7 commits into from
Jun 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,11 @@ jobs:
uses: ./
with:
entrypoint: example/one-of/entrypoint.sh
- name: Run stub subfolders example
uses: ./
with:
entrypoint: example/stub-subfolders/entrypoint.sh
- name: Run no go_package example
uses: ./
with:
entrypoint: example/no-gopackage/entrypoint.sh
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ pkged.go
gripmock
.idea
.DS_Store
protogen
6 changes: 6 additions & 0 deletions example/no-gopackage/bar/bar.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
syntax = "proto3";
package bar;

message Bar{
string name = 1;
}
6 changes: 6 additions & 0 deletions example/no-gopackage/bar/deep/bar.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
syntax = "proto3";
package bar;

message DeepBar{
string address = 1;
}
38 changes: 38 additions & 0 deletions example/no-gopackage/client/main.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package main

import (
"context"
"log"
"os"
"time"

pb "github.com/tokopedia/gripmock/protogen/example/no-gopackage"
no_gopackage "github.com/tokopedia/gripmock/protogen/example/no-gopackage/bar"
"google.golang.org/grpc"
)

//go:generate protoc --go_out=plugins=grpc:${GOPATH}/src -I=../../protogen ../hello.proto ../foo.proto ../bar/bar.proto ../bar/deep/bar.proto
func main() {
ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
defer cancel()

// Set up a connection to the server.
conn, err := grpc.DialContext(ctx, "localhost:4770", grpc.WithInsecure(), grpc.WithBlock())
if err != nil {
log.Fatalf("did not connect: %v", err)
}
defer conn.Close()

c := pb.NewGripmockClient(conn)

// Contact the server and print out its response.
name := "tokopedia"
if len(os.Args) > 1 {
name = os.Args[1]
}
r, err := c.Greet(context.Background(), &no_gopackage.Bar{Name: name})
if err != nil {
log.Fatalf("error from grpc: %v", err)
}
log.Printf("Greeting: %s\nAddress:%s", r.Response, r.Deepbar.Address)
}
13 changes: 13 additions & 0 deletions example/no-gopackage/entrypoint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/usr/bin/env sh

# this file is used by .github/workflows/integration-test.yml

gripmock --stub=example/no-gopackage/stub \
example/no-gopackage/foo.proto example/no-gopackage/hello.proto \
example/no-gopackage/bar/bar.proto \
example/no-gopackage/bar/deep/bar.proto &

# wait for generated files to be available and gripmock is up
sleep 2

go run example/no-gopackage/client/*.go
12 changes: 12 additions & 0 deletions example/no-gopackage/foo.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
syntax = "proto3";

// simulating neighboring .proto file
// but different package
package foo;

import "bar/deep/bar.proto";

message Response {
string response = 1;
bar.DeepBar deepbar = 2;
}
11 changes: 11 additions & 0 deletions example/no-gopackage/hello.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
syntax = "proto3";

package multi_package;

import "bar/bar.proto";
import "foo.proto";

service Gripmock {
rpc Greet (bar.Bar) returns (foo.Response);
}

17 changes: 17 additions & 0 deletions example/no-gopackage/stub/simple.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"service":"Gripmock",
"method":"Greet",
"input":{
"equals":{
"name":"tokopedia"
}
},
"output":{
"data":{
"response":"Hello Tokopedia",
"deepbar": {
"address": "Jakarta"
}
}
}
}
33 changes: 33 additions & 0 deletions fix_gopackage.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
#!/bin/bash

protos=("$@")

for proto in "${protos[@]}"
do
if grep '^option go_package' $proto;then
echo "option go_package detected in $proto, no need to append"
exit 1
fi
done

for proto in "${protos[@]}"
do
if [[ -d $proto ]]; then
continue
fi

dir=${proto%/*}
file=${proto##*/}

newdir="protogen/$dir"
newfile="$newdir/$file"
# copy to protogen directory
mkdir -p "$newdir" && cp "$proto" "$_"

syntaxLineNum="$(grep -n "syntax" "$newfile" | head -n 1 | cut -d: -f1)"

goPackageString="option go_package = \"github.com/tokopedia/gripmock/protogen/$dir\";"
sed -i "${syntaxLineNum}s~$~\n$goPackageString~" $newfile
echo $newfile
done

27 changes: 13 additions & 14 deletions gripmock.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package main

import (
"bytes"
"flag"
"fmt"
"log"
Expand Down Expand Up @@ -85,12 +86,6 @@ func main() {
}
}

func getProtoName(path string) string {
paths := strings.Split(path, "/")
filename := paths[len(paths)-1]
return strings.Split(filename, ".")[0]
}

type protocParam struct {
protoPath []string
adminPort string
Expand All @@ -101,6 +96,7 @@ type protocParam struct {
}

func generateProtoc(param protocParam) {
param.protoPath = fixGoPackage(param.protoPath)
protodirs := strings.Split(param.protoPath[0], "/")
protodir := ""
if len(protodirs) > 0 {
Expand Down Expand Up @@ -130,16 +126,19 @@ func generateProtoc(param protocParam) {

}

func buildServer(output string) {
args := []string{"build", "-o", output + "grpcserver", output}

build := exec.Command("go", args...)
build.Stdout = os.Stdout
build.Stderr = os.Stderr
err := build.Run()
// append gopackage in proto files if doesn't have any
func fixGoPackage(protoPaths []string) []string {
fixgopackage := exec.Command("fix_gopackage.sh", protoPaths...)
buf := &bytes.Buffer{}
fixgopackage.Stdout = buf
fixgopackage.Stderr = os.Stderr
err := fixgopackage.Run()
if err != nil {
log.Fatal(err)
log.Println("error on fixGoPackage", err)
return protoPaths
}

return strings.Split(strings.TrimRight(buf.String(), "\n"), "\n")
}

func runGrpcServer(output string) (*exec.Cmd, <-chan error) {
Expand Down