Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The shortcut keys for secondary subtitles actions do not work #965

Closed
dyphire opened this issue Sep 1, 2024 · 5 comments
Closed

The shortcut keys for secondary subtitles actions do not work #965

dyphire opened this issue Sep 1, 2024 · 5 comments

Comments

@dyphire
Copy link
Contributor

dyphire commented Sep 1, 2024 •
edited
Loading

Buttons work fine.

Edit: By the way, the alt shortcut doesn't work either.
@hooke007
Copy link
Contributor

hooke007 commented Sep 1, 2024

The shortcut key for secondary subtitles is shift+(enter)

@dyphire
Copy link
Contributor Author

dyphire commented Sep 1, 2024

Well, it's very misleading.

@dyphire dyphire closed this as completed Sep 1, 2024
@tomasklaen
Copy link
Owner

I only added (shift) to the label because it can be used for both enter and mouse click to activate secondary subtitle, and adding (shift+enter, shift+click) seemed too long.

I was hoping none would think that modifier on its own would have a function.

@mrfragger
Copy link

yea I would've never figured it out without reading this thread and another thread...perhaps two lines. I kept hitting shift and couldn't figure out what was supposed to happen.
Activate as secondary subs
(shift+ENTER or shift+click)

@tomasklaen
Copy link
Owner

Fair enough, I'll rephrase the label.

tomasklaen added a commit that referenced this issue Sep 1, 2024
@tomasklaen
feat: various menu actions adjustments
3215c13 
We now only display actions outside the menu when hint or icon have a high informational value and shouldn't be covered by buttons (like track menus).

Up/down reordering buttons in playlist menu have been removed. A bit too much clutter, and reordering by clicking these was not a good UX anyway. The info about what shortcuts can be used to reorder items is now available in menu footer.

Clarified shortcut alternatives to various menu actions in their labels.

And some action icon changes.

ref #965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hooke007 @tomasklaen @dyphire @mrfragger