-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize track title and update Chinese translation #975
Conversation
You should reuse the existing Lua pattern escape code: uosc/src/uosc/elements/TopBar.lua Line 68 in 3621e0b
|
0a668d5
to
38a8753
Compare
Missed it. |
38a8753
to
112fc7e
Compare
I did at first but when it was an external track the track title was the filename this could not be empty.
I improved it and it looks much better now.
I would say that's fine too, even so this PR is still a nice improvement. |
if track.lang and track.title:lower() == track.lang:lower() then
track.title = nil
end What is this for? Track title in here will always contain extension, so it will never match lang, no? |
No, the |
112fc7e
to
97a3c64
Compare
There was a small error that has been fixed. |
97a3c64
to
5d81d9c
Compare
5d81d9c
to
147c9e0
Compare
There's a crash when subtitle menu is opened when nothing is playing:
|
Fixed. Thx for catching that. Was about to cut a new minor. |
ref #964