Remove cast of associated store identifier values when serializing. A…

…dd test condition.
tomasmcguinness · Mar 21, 2023 · 40e9e95 · 40e9e95
1 parent c118590
commit 40e9e95
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/Passbook.Generator.Tests/GeneratorTests.cs b/Passbook.Generator.Tests/GeneratorTests.cs
@@ -33,6 +33,8 @@ public void EnsurePassIsGeneratedCorrectly()
                 Row = 1
             });
 
+            request.AssociatedStoreIdentifiers.Add(long.MaxValue);
+
             using (MemoryStream ms = new MemoryStream())
             {
                 using (StreamWriter sr = new StreamWriter(ms))
@@ -65,6 +67,10 @@ public void EnsurePassIsGeneratedCorrectly()
                     Assert.Equal("Test", (string)auxField["value"]);
                     Assert.Equal("Label", (string)auxField["label"]);
                     Assert.Equal(1, (int)auxField["row"]);
+
+                    var associatedAppIdentifiersPayload = (JArray)json["associatedStoreIdentifiers"];
+                    Assert.Single(associatedAppIdentifiersPayload);
+                    Assert.Equal(long.MaxValue, associatedAppIdentifiersPayload[0]);
                 }
             }
         }

diff --git a/Passbook.Generator/PassGenerator.cs b/Passbook.Generator/PassGenerator.cs
@@ -64,7 +64,7 @@ public byte[] Generate(IReadOnlyList<PassGeneratorRequest> generatorRequests)
                 throw new ArgumentNullException(nameof(generatorRequests), "You must pass an instance of IReadOnlyList containing at least one PassGeneratorRequest");
             }
 
-            if (generatorRequests.Count() == 0)
+            if (!generatorRequests.Any())
             {
                 throw new ArgumentException(nameof(generatorRequests), "The IReadOnlyList must contain at least one PassGeneratorRequest");
             }

diff --git a/Passbook.Generator/PassGeneratorRequest.cs b/Passbook.Generator/PassGeneratorRequest.cs
@@ -526,7 +526,7 @@ private void WriteStandardKeys(JsonWriter writer)
                 writer.WritePropertyName("associatedStoreIdentifiers");
                 writer.WriteStartArray();
 
-                foreach (int storeIdentifier in AssociatedStoreIdentifiers)
+                foreach (var storeIdentifier in AssociatedStoreIdentifiers)
                 {
                     writer.WriteValue(storeIdentifier);
                 }

diff --git a/Passbook.Generator/Passbook.Generator.csproj b/Passbook.Generator/Passbook.Generator.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
-    <Version>3.2.2.0</Version>
+    <Version>3.2.3.0</Version>
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
     <PackageId>dotnet-passbook</PackageId>
     <Company>Tomas McGuinness</Company>