BUGFIX: Typecast PageTS Crawler Configuration force_ssl to int (#1112)

tomasnorre · Oct 10, 2024 · 0b137a0 · 0b137a0
1 parent bee4ff8
commit 0b137a0
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/.github/workflows/BackwardCompatibilityCheck.yml b/.github/workflows/BackwardCompatibilityCheck.yml
@@ -48,5 +48,5 @@ jobs:
           # To ensure compability with the roave tool.
           composer remove --dev nimut/typo3-complete nimut/testing-framework rector/rector symplify/easy-coding-standard typo3/testing-framework
           rm -rf .Build composer.lock
-          composer require --dev roave/backward-compatibility-check:"6.0.x-dev"
-          .Build/bin/roave-backward-compatibility-check
+          composer require --dev roave/backward-compatibility-check:"^6.4"
+          .Build/bin/roave-backward-compatibility-check --from=11.0.0
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 
 ### Fixed
 * Fixed query building when using _ADDTABLE parameter [@hawkeye1909](https://github.com/hawkeye1909)
+* Typecast PageTS Crawler Configuration `force_ssl` to `int`
 
 ### Deprecated
 

diff --git a/Classes/Controller/CrawlerController.php b/Classes/Controller/CrawlerController.php
@@ -319,7 +319,7 @@ public function urlListFromUrlArray(
                 $pageId,
                 $urlQuery,
                 $vv['subCfg']['baseUrl'] ?? null,
-                $vv['subCfg']['force_ssl'] ?? 0
+                (int) ($vv['subCfg']['force_ssl'] ?? 0)
             );
 
             if (! $url instanceof UriInterface) {

diff --git a/Documentation/Configuration/PageTsconfigReference(txCrawlercrawlercfg)/Index.rst b/Documentation/Configuration/PageTsconfigReference(txCrawlercrawlercfg)/Index.rst
@@ -136,6 +136,20 @@ Page TSconfig Reference (tx\_crawler.crawlerCfg)
          List of Page Ids to limit this configuration to
 
 
+.. container:: table-row
+
+   Property
+         .. _crawler-tsconfig-paramSets-key-force_ssl:
+
+         paramSets.[key].force_ssl
+
+   Data type
+         integer
+
+   Description
+         Whether https should be inforced or not. 0 = false (default), 1 = true.
+
+
 .. container:: table-row
 
    Property
@@ -183,5 +197,6 @@ Example
       procInstrFilter = tx_indexedsearch_reindex
       pidsOnly = 1,5,13,55
       userGroups = 1
+      force_ssl = 1
    }