Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Change tense in flush command message #1017

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

cweiske
Copy link
Contributor

@cweiske cweiske commented May 25, 2023

.. the repository has already been flushed already when the message is shown. No need to say it "will be" flushed in the future.

Description

The time form in the flush command status message is wrong:

$ ./vendor/bin/typo3cms crawler:flushQueue all
All entries in Crawler queue will be flushed

The repository already deleted the data when the message is shown.

This PR changes the message to past tense to indicate this.

I have

  • Checked that CGL are followed
  • Checked that the Tests are still working (I hope CI does)
  • Added description to CHANGELOG.md

@tomasnorre
Copy link
Owner

Thanks for your contribution. Looks like I need to update the compose.json of the main branch to have the CI green again.

@stale
Copy link

stale bot commented Jul 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Jul 24, 2023
@tomasnorre tomasnorre removed the staled label Jul 25, 2023
@tomasnorre
Copy link
Owner

Is it possible that you could rebase this, to solve conflicts, then I'll be happy to merge this.

.. the repository has already been flushed already when the message is shown.
No need to say it "will be" flushed in the future.
@cweiske
Copy link
Contributor Author

cweiske commented Feb 15, 2024

Rebased.

@tomasnorre tomasnorre merged commit 1ce6332 into tomasnorre:main Feb 15, 2024
2 of 29 checks passed
@cweiske cweiske deleted the flush-tense branch January 14, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants