Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Typecast PageTS Crawler Configuration force_ssl to int #1095

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

tomasnorre
Copy link
Owner

@tomasnorre tomasnorre commented Oct 6, 2024

Description

This typecasts force_ssl to int PageTS Crawler Configurations.
Resolves #1000

I have

  • Checked that CGL are followed
  • Checked that the Tests are still working
  • Added description to CHANGELOG.md (github-handle is optional)
  • Added tests for the new code

@tomasnorre
Copy link
Owner Author

@SventB Can you please confirm that this PR works for you?

@tomasnorre tomasnorre removed the v11.x label Oct 10, 2024
@tomasnorre tomasnorre merged commit 84ad9a2 into main Oct 10, 2024
34 of 35 checks passed
@tomasnorre tomasnorre deleted the issue/1000 branch October 10, 2024 07:54
@SventB
Copy link

SventB commented Oct 13, 2024

Hi @tomasnorre,

thank you for the fix. I can't check this now and I don't know how to reproduce this, it's so long ago I've reported this and I have no TYPO3 test installation with working EXT:crawler and I only used EXT:crawler with TYPO3 v11.

@tomasnorre
Copy link
Owner Author

Ok. I'll make a new release in near future and hope no one else experiences it.
Thanks for getting back to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Page TSconfig
2 participants