Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/trusted host pattern failing #899

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Bugfix/trusted host pattern failing #899

merged 3 commits into from
Feb 10, 2022

Conversation

andreashager
Copy link
Contributor

@andreashager andreashager commented Feb 10, 2022

Description

The problem was that the crawler could not crawl websites in the frontend on the production server. The problem was a trusted host pattern fail due to the check of the server port that was never been set: https://github.com/TYPO3/typo3/blob/10.4/typo3/sysext/core/Classes/Utility/GeneralUtility.php#L2929

Additionally a type mismatch error on the crawler log in the backend was fixed.

Maybe this could be the same problem as described in #757 🤔

I have

  • Checked that CGL are followed
  • Checked that the Tests are still working
  • Added description to CHANGELOG.md (github-handle is optional)
  • Added tests for the new code

@tomasnorre
Copy link
Owner

Super! Thank you for taking the time to create your first pull request. Please give us a bit of time to review it.

Copy link
Owner

@tomasnorre tomasnorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you please take care of the Static Code Analysis warnings from cs-fixer and PHPStan

@andreashager
Copy link
Contributor Author

I changed my code that the CS-Fixer and PHP Stan warning is gone 😄

@tomasnorre
Copy link
Owner

Thanks, will check out again later, merge and release a new version.
Thanks for your contribution.

@andreashager
Copy link
Contributor Author

Cool thanks 🥳
Than I can remove my local patches again 😃

@tomasnorre tomasnorre merged commit 2a099cf into tomasnorre:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants