Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use julia version 1.10 on ci #166

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Use julia version 1.10 on ci #166

merged 2 commits into from
Mar 25, 2024

Conversation

jbisits
Copy link
Collaborator

@jbisits jbisits commented Mar 25, 2024

I ran into some issues with the tests (see here) on ci after merging #163. Updating ci to run on julia v1.10 has solved this.

Closes #165

@jbisits jbisits requested a review from tomchor March 25, 2024 04:41
Copy link
Owner

@tomchor tomchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! It's weird that the tests passed in the other PR but not on ci though...

Hopefully this works!

@jbisits
Copy link
Collaborator Author

jbisits commented Mar 25, 2024

Nice catch, thanks! It's weird that the tests passed in the other PR but not on ci though...

Hopefully this works!

Yeah I am not quite sure why ci did not run on julia v1.9. I will try on a machine with v1.9 and check all works though.

@jbisits jbisits merged commit f5fbff7 into main Mar 25, 2024
2 checks passed
@jbisits jbisits deleted the jib-patch branch March 25, 2024 21:26
@tomchor
Copy link
Owner

tomchor commented Mar 26, 2024

CI is working now after this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test errors after merging #163
2 participants