-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background potential energy computation #172
Open
jbisits
wants to merge
41
commits into
main
Choose a base branch
from
jib-background-potential-energy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
5efa6a6
Try some sorting idea for background state
jbisits 7113697
First attempt at bpe implementation
jbisits 1590116
Change docstring example
jbisits 8ace5a8
Add space
jbisits 5d2eee1
`sort` reverse so that matches `z`
jbisits 84265a8
`sort(rev=true)` for density only (not buoyancy)
jbisits 44d81c5
Removed wrong thing
jbisits 9362a27
Correction in docstring
jbisits fbe8c02
Cleanup function definitions
jbisits e59fbad
Remove bad Type design
jbisits 1ac15f3
Using more kfo's
jbisits 6d3d7da
Update PotentialEnergyEquationTerms.jl
jbisits 62b0a47
Update BPE docstring
jbisits 1c73077
Update src/PotentialEnergyEquationTerms.jl
jbisits 2c4faad
Try `OneDReferenceField`
jbisits 0a87fbb
Export the function
jbisits 73479d5
Correct BPE function, still need to check sorting
jbisits dfbbcd4
Merge branch 'main' into jib-background-potential-energy
jbisits f28a26a
Suppress some docstring output
jbisits aad59a9
Docstring updates
jbisits 6251dc8
Validate model grid + docstring updates
jbisits 2e98f34
Update src/PotentialEnergyEquationTerms.jl
jbisits 38b9a83
Update PotentialEnergyEquationTerms.jl
jbisits 24b658c
Merge branch 'jib-background-potential-energy' of https://github.com/…
jbisits 3107ec6
Update src/PotentialEnergyEquationTerms.jl
jbisits 23d095d
Update src/PotentialEnergyEquationTerms.jl
jbisits 769ecc0
Wrong function calls
jbisits 44c0206
Reduce number of methods + update packages
jbisits ac0ed37
Default to `geopotential_height = 0`
jbisits 8689673
Simplify testing
jbisits 8219b78
Correct misaligned brackets
jbisits 71b5537
Add tests for `OneDReferenceField` + bpe
jbisits 82c2421
Test z*
jbisits d4d396e
Docstring updates
jbisits 63a58b2
Align `z` and `z✶`
jbisits 3f752bf
Missed the ✶
jbisits 1fd9d64
Correct `BuoyancyTracer()` and linear eos sorting
jbisits 7514adf
Update `Type` input for `OneDReferenceField`
jbisits 7cbc052
Correct function call
jbisits 2ec9e41
Merge branch 'main' into jib-background-potential-energy
jbisits 08832ae
Merge branch 'main' into jib-background-potential-energy
tomchor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line doesn't read well. But I also don't have immediate suggestions on how to improve it... irrc the whole nomenclature of
BuoyancyModel
is kinda confusing and we discussed changing it over at Oceananigans a few times.Maybe changing it from
buoyancy_model
tobuoyancy_treatment
might help...?