-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: replace_refs_factory() missing 1 required positional argument: 'target' #46
Comments
Do you mean MAJOR or MINOR. My understanding is that you're proposing that breaking API changes in the pandoc-xnos architecture would increment the MAJOR version? In other words, the idea here is to make sure fignos and xnos are both using the same MAJOR, or the same MAJOR.MINOR? |
My mistake. It is the MAJOR version number that I should be changing in pandoc-xnos when there are API changes. Pandoc-fignos will require a particular MAJOR version number of the pandoc-xnos library. This will be written into the pandoc-fignos setup, so it should be completely transparent to users. Thanks for the feedback. |
Got it! Makes sense to me. |
pandoc-xnos 1.0.1 is now released, and the requirement that pandoc-fignos use pandoc-xnos>=1.0.1,<2 is published in the I don't think that publishing a new release is urgent, but users should let me know if they disagree. Otherwise the changes will go out when I have finished some other work in the queue. I also want to keep this Issue open in case others encounter the same problem. |
Should upstream fix issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
Fix upstream issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
This build is based on 310dd07. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/manubot-rootstock/builds/338192586 https://travis-ci.org/greenelab/manubot-rootstock/jobs/338192587 [ci skip] The full commit message that triggered this build is copied below: Update environment on 2018-02-06 (#108) Fix upstream issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
This build is based on 310dd07. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/manubot-rootstock/builds/338192586 https://travis-ci.org/greenelab/manubot-rootstock/jobs/338192587 [ci skip] The full commit message that triggered this build is copied below: Update environment on 2018-02-06 (#108) Fix upstream issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
I'm closing this in anticipation of a new release today. |
Fix upstream issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
Fix upstream issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
The above error with pandoc-fignos was reported at greenelab/deep-review:
The problem: There is an API incompatibility between pandoc-fignos 1.0.0 and pandoc-xnos 0.15 (the library for the pandoc-xnos/eqnos/tablenos filters).
The solution: Upgrade to the most recent version of pandoc-fignos.
I would like to prevent such errors from occurring in the future. One way forward is to move pandoc-xnos to MAJOR.MINOR.PATCH versioning and require a particular MAJOR.MINOR version for a given pandoc-fignos release. The MINOR number would be incremented for API changes.
Feedback is welcome.
The text was updated successfully, but these errors were encountered: