Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest noon for raw day datetimes. #361

Closed
wants to merge 1 commit into from
Closed

Suggest noon for raw day datetimes. #361

wants to merge 1 commit into from

Conversation

mojombo
Copy link
Member

@mojombo mojombo commented Oct 20, 2015

Suggesting 00:00:00 for datetimes that have only their day specified might cause problems due to daylight savings time and leap changes. Suggesting noon should avoid any of those problems.

@mwanji
Copy link
Contributor

mwanji commented Oct 22, 2015

It might be better to suggest using a date library that handles these sorts of things properly.

For example, in Java 8 there is LocalDate#atStartOfDay which gets the first existing time of the given date.

@ChristianSi
Copy link
Contributor

Looks good -- though #362 has some merit too.

@HuwCampbell
Copy link

So better (in that it won't crash), but still very problematic.
As an example: company in Sydney has an offer with an expiry date. They encode this in TOML. Customer in Sydney finds they can't use their coupon past midday, even worse, customer in Perth can't use theirs past 9am.
Mixing instants and dates, and local datetimes is going to be problematic. If an international company schedules exercise for their workers for 2pm local, it's not the same as scheduling a conference call for 2pm EST. This should be clear if they want to express these schedules in TOML.

@mojombo
Copy link
Member Author

mojombo commented Jan 3, 2017

No longer relevant due to #414.

@mojombo mojombo closed this Jan 3, 2017
@mojombo mojombo deleted the noon-time branch February 5, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants