Allow multiple newlines and comments in multiline arrays #490
Conversation
pradyunsg
force-pushed
the
revisit-array
branch
from
347d3a1 to
deb40eb
Compare
No real functional change here, just a more one-to-one correspondance.
|
I would change the ABNF as suggested (provided it works -- didn't check), but leave the README unchanged. The old wording is IMHO good enough, while the new one is confusing and occasionally misleading. ("Multiline arrays ignore whitespace everywhere between the brackets." -- What? Single-line arrays ignore whitespace [i.e., spaces and tabs] too.) |
Actually, you're right. That sentence is redundant. I'll 🔥 it. |
|
@ChristianSi Does this look better? |
|
@pradyunsg Looks much better to me, thanks! Sadly I'm not in any way "officially" involved with TOML and the maintainers seem to have gone on an extended (read: possible infinite) vacation, so I'm not sure whether that'll get you anywhere... |
|
Thanks @ChristianSi! Indeed. I know that. :) I just figured it might be a good idea to make it as easy as clicking a button to actually fix some of the things that are needed for a 1.0.0 as per @BurntSushi. If the maintainers still take forever to come around to this or come around to this in the next minute, I don't mind either way. I do strongly prefer the latter. :P |
|
Hey @pradyunsg, thanks for putting together these ABNF improvements! Merging this one as-is. |
Closes #487
Closes #458
Closes #448
This is a modification to allow an arbitrary number of comments and newline in multiline arrays, instead of a fairly inconsistent format as currently specified.