IP address values can be unquoted #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this violating the rule of "one way to do something"? IP addresses seem to be standalone data types in that they have meaning on their own so why should we treat them like strings? I can see some potential complexity in implementation. Thoughts on this?
|
Related discussion in #62. Difference here being the IP address has semantic meaning rather than just being an unquoted string. |
|
Note: 127.1 is a valid IPv4 address. |
|
should include block notation (/24) and ipv6 (::1) |
|
I don't think IP addresses warrant their own data type. They can be expressed quite well as strings, and many languages won't have native IP types to map to. This would also add a ton of weight to the spec to get right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this violating the rule of "one way to do something"? IP addresses seem to be standalone data types in that they have meaning on their own so why should we treat them like strings? I can see some potential complexity in implementation. Thoughts on this?