Known bug fixes and improvements #359
Conversation
…ar rather than the event details (tap the event title for the details).
1. UpdateCalendarService will fetch all events from now to the next fetch time + Preferences.showUntil, so that EventRepository holds all events need to be shown before the next fetch; 2. Every event is updated 1 minute after the corresponding time span, to make the actual time difference consistent with the displayed getRelativeTimeSpanString; 3. Update events only when necessary, eliminate redundant alarms; cancel all update alarms when showEvents is turned off.
# Conflicts: # app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/AlignedWidget.kt # app/src/main/java/com/tommasoberlose/anotherwidget/ui/widgets/StandardWidget.kt
Adjust the layout carefully, so that remote grid views perfectly overlap the bitmap generated from the binding view, whether left-aligned, right-aligned or centered, and regardless of the size of the widget, text, margins or spacing. Display the clock in the correct text size.
# Conflicts: # app/src/main/java/com/tommasoberlose/anotherwidget/helpers/WeatherHelper.kt
|
Hi @azuo! I'm absolutely astonished by the major changes that you've added to this PR, thank you so much for helping me. I've quickly gone through all the commits you pushed and I'll run some tests asap but, in the meantime, I have a few questions for you:
Thank you again for the major work you've done. |
|
This widget is great, and I like it so much that I can't resist fixing any bugs I encountered while using it. But in order not to interfere or conflict with your ideas, I just make fixes or patches, but try to avoid adding, removing or refactoring any features. Migrating to Androd 12 may involve some changes that go well beyond "fixes" or "patches", but I will be happy to help if I can. |
|
Any help is always appreciated! I'll handle the Android 12 transition in a specific branch once I'll have time to work on the widget for a while. Because I want to integrate the dynamic color feature inside the app as the first step and then moving forward to integrate it inside the widget customization system. In the meantime, we definitely have to find another way to get the location of the devices while in the background, without using the permissions to access it from the background or the FINE_ACCESS one. Would be feasible for you to revert only the changes that cover this part to the way they were before? |
1. Replace foreground services with Workers 2. Support approximate location 3. Fallback to inexact alarms if the SCHEDULE_EXACT_ALARM permission is revoked 4. Specify the mutability of each PendingIntent 5. Explicitly declare the android:exported attribute for app components that use intent filters
|
@tommasoberlose, Play Store has rejected a version due to the use of some kind of foreground service to access the location, right? But specifically because of foreground service or access the location in the background? Well, the foreground service can be replaced with a Worker, and ACCESS_FINE_LOCATION can be replaced with ACCESS_COARSE_LOCATION, but why can't we use ACCESS_BACKGROUND_LOCATION? I think ACCESS_BACKGROUND_LOCATION is an absolute must. Without using geolocation in the background, the weather information would be very inaccurate, if not completely useless. I investigated several top-ranking widget apps in Play Store that show weather, all of them use both ACCESS_FINE_LOCATION and ACCESS_BACKGROUND_LOCATION permissions, for example, Weather & Clock Widget for Android (API 29, 50M+ installs), As with the above apps, it might be helpful to display a prominent prompt immediately after the app is launched? |
1. Adapt the location callback in WeatherWorker to coroutines 2. Merge EventListenerJob into UpdateCalendarWorker 3. Remove BatteryListenerJob, as it's impossible to use Jobs to detect battery status
|
@azuo I sincerely admire the comprehensive work you have done. Thanks! |
|
Wow, can't wait update to arrive to play store! Amazing work! |
|
Is this going to be merged for a new version? |
|
Dang, you've done a lot of work on this! Hope to see these changes get pushed to the main branch soon! :) |
|
Hoping for the release push :) |
Location & weather
Calendar & events
Widget UI
Miscellaneous
Fixed issues
#288, #293, #318, #321, #326, #328, #330, #338, #340, #342, #343, #353