-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dots indicator initialises with the wrong number of dots initially #20
Comments
Hmmm.. i just checked the code again - looks like i have a different version than what is in the maven rep... You removed that code. Ok i will try to get that version. You obviously fixed this bug. |
Oh actually the problem is in SpringDotsIndicator. I was looking in DotsIndicator. So this is still a problem. |
This problem is also existent on the WormDotsIndicator too. Any updates on this? |
Hello @createS0ftware and @GalatiaPar, I can't reproduce the bug of the three dots instead of two. Does the new release 3.0.2 fix the issue ? |
Hi @tommybuonomo. Not really. I can see a different issue arising depending on the case:
I hope this helps. If you need any more clarifications please do not hesitate to ask! |
@GalatiaPar can you check now with 3.0.3 please ? |
@tommybuonomo all seems to be working well! thank you! Keep up the great work 👍 |
I'll check it in the next few hours |
Fixed !! Well done !! Thanks !! |
I am still facing the same problem with the wrong number of dots in 3.0.3 |
I have 2 items in my viewpager and the dots indicator initialises with 3 dots
I can't see why - but if is set the viewpager to the second page then it initialises with 2 dots.
i think the problem is that in refreshDots() you call buildDot which adds a child view (dot) to the layout - if dotIndicatorView is not initialised.
You need to remove this view after you find that the viewpager adapter has pages - in that same refreshDots() method
The text was updated successfully, but these errors were encountered: