Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dots Not Updated When Using ViewPager2 + ListAdapter #78

Closed
cocoahero opened this issue Feb 20, 2020 · 1 comment
Closed

Dots Not Updated When Using ViewPager2 + ListAdapter #78

cocoahero opened this issue Feb 20, 2020 · 1 comment
Assignees
@tommybuonomo
Labels
bug
Milestone
4.3

Comments

@cocoahero
Copy link

When using a ListAdapter with ViewPager2, the dots indicator does not properly respond to data changes in the adapter.

It appears that this is because only the onChanged callback of AdapterDataObserver is implemented. When using a ListAdapter, it utilizes the much more granular callbacks of AdapterDataObserver instead of onChanged.

This appears related to #73.
aloj22 added a commit to aloj22/dotsindicator that referenced this issue Mar 25, 2021
@aloj22
[fix tommybuonomo#109 tommybuonomo#84 tommybuonomo#78 ] Refresh dots …
4dc08c8 
…when onItemRangeInserted or onItemRangeRemoved called
@aloj22 aloj22 mentioned this issue Mar 25, 2021
Closed
@tommybuonomo tommybuonomo self-assigned this Apr 30, 2022
@tommybuonomo tommybuonomo added this to the 4.3 milestone Apr 30, 2022
@tommybuonomo tommybuonomo mentioned this issue Apr 30, 2022
Closed
@tommybuonomo
Copy link
Owner

Hello, thanks for your contribution !
This issue is now fixed in the new version 4.3
Thanks 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommybuonomo tommybuonomo

Labels
bug
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
2 participants
@cocoahero @tommybuonomo